PUP Plugin not working

[Julian X]

🎯Description of the issue

PUP Plugin does not work on MyBB 1.8.24 (Latest Version)

▶🚶‍Reproduction steps

Defauly MyBB -> Insert Header Code -> No button on textarea. This is solved by placing the PUP code above general.js in the header template.

Upload image with "BBCode Full" (no link) turned on.

BUT, any uploads aren't "returned" back to the MyBB Host. The script uploads as usual, but then closes the window to a blank MyBB textarea with no upload


😢Unexpected result

No embed code in the MyBB Text Area

📃Error log message

[Provide any relevant error log entry. You may check our documentation for help on this]

 

[Julian X]

Just an update, for quick reply, where the code buttons are NOT used, the auto embed insert works.

Its just when then sceditor is loaded, that it doesn't

 

[Julian X]

Apologies, I am new, does this mean you acknowledge the bug and are looking into it ?

I understand you are a single developer, and I don't expect a quick result unless it's a small fix, but I don't know if this means we have to live with this or if you are fixing it ?

 

[Julian X]

Any update on this ?

 

[Rodolfo]

For MyBB (and perhaps other software) will require a code like this to work:

<script>
(function pupWaitForMyBB() {
    if(typeof MyBB !== typeof undefined) {
        var script = document.createElement('script');
            script.type = 'text/javascript';
            script.src = '//botfiles.co/sdk/pup.js';
            script.dataset.url = 'https://botfiles.co/upload';
            document.head.appendChild(script);
        clearTimeout(this.pupWaitForMyBB);
    } else{
        setTimeout(this.pupWaitForMyBB, 250);
    }
})();
</script>

This is just a quirk from the implementation as MyBB doesn't have the variable ready when pup.js gets called.