Reviewing All password protected albums have same name "Private album"

[user_5207e]

All password protected albums have same name "Private album". Hence, users can't distinguish which one is which.

Reproduction steps

1. Create an album
2. Set privacy to Private(Password protected)
3. Go to album list. (see screenshot)

Unexpected result

All albums have name "Private album" and no way for the user to see which is which album. But for admins it shows name and cover pic.

Error log message

 

[user_5207e]

Issue seems to be with this line of code in functions-render.php. Commenting this code make the album name visible again. But not sure how to fix it.

    if ($stock_tpl === 'ALBUM' && $isRequesterAdmin === false && $item['privacy'] === 'password' && ! ($item['user']['id'] && $item['user']['id'] === ($requester['id'] ?? null)) && Album::checkSessionPassword($item) === false) {
        $fill_tpl = 'album_password';
    }

 

[Rodolfo]

We consider all the album content as private, including its title. The padlock should be visible only to third-parties, both owner and admin should be able to see the album name/image on list.

Can you indicate in which context does the padlock show up wrong?