Plural forms error

[Wink]

lib\G\classes\class.gettext.php

    private function parsePluralData($header)
    {
...
            $nplurals = (int) $matches[1];
            if (preg_match('/^([!n\=\<\>\&\|\?\:%\s\(\)\d]+)$/', $matches[2]) === true) {
                $formula = $matches[2];
            }
...
    }

MUST be

            if (preg_match('/^([!n\=\<\>\&\|\?\:%\s\(\)\d]+)$/', $matches[2])) {
                $formula = $matches[2];
            }

...because preg_match return only 0, 1 or false, but never true

Because of this error, all plural forms do not work at all for all languages with more then 2 plural forms.

 

[Rodolfo]

Thank you, you are right. Thanks for pointing out.

This will get patched in V3.20.20 and V4.0.0.

 

[Wink]

Another problem with plurals in app\lib\classes\class.listing.php inside function getTabs()

        $contents = [
            'images' => [
                'icon' => $listings['images']['icon'],
                'label' => _n('Image', 'Images', 2),
            ],
            'albums' => [
                'icon' => $listings['albums']['icon'],
                'label' => _n('Album', 'Albums', 2),
            ],
            'users' => [
                'icon' => $listings['users']['icon'],
                'label' => _n('User', 'Users', 2),
            ]
        ];

We need something like this

        $contents = [
            'images' => [
                'icon' => $listings['images']['icon'],
                'label' => _s('Images'),
            ],
            'albums' => [
                'icon' => $listings['albums']['icon'],
                'label' => _s('Albums'),
            ],
            'users' => [
                'icon' => $listings['users']['icon'],
                'label' => _s('Users'),
            ]
        ];

Because it's not the same for some languages. For example in russian
"Albums" = "Альбомы" but "2 Albums" = "2 Альбома"
"Users" = "Пользователи" but "2 Users" = "2 Пользователя"

 

[Rodolfo]

Fixed in v4.0.0