JavaScript Error When Clicking on External Storage Links (v4 beta 10)

[snapetom]

Not sure if this is related to the pathstyle-url issue, but Im having a frontend issue when I try to edit an External Storage in the dashboard settings. Apparently, I can add a new one just fine. There is a JS error on page load and subsequently, the links are not clickable.

I just upgraded to v4 beta 10 from V3. It now appears that the storage_bucket, storage_key, storage_secret columns in the xxx_storage table on the new S3 bucket is hashed while the existing one did not get hashed. Not sure if this is relevant.

▶ Reproduction steps

1. Go to /dashboard/settings/external-storage. See error message below.
2. Click on any of the External Storage names. Nothing happens. (Error message below)
3. Click on the "Active" Checkbox of an S3 bucket. Nothing happens (Error message below)

😢 Unexpected result

A popup to edit the external storage should appear

📃 Error log message

On /eternal-storage page load:

Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.
Uncaught SyntaxError: Unexpected token ';' (at external-storage:770:25)

<form id="dashboard-settings" method="post" data-type="settings" data-action="validate" enctype="multipart/form-data">
  <input type="hidden" name="auth_token" value="ede201622622216d111190f4beeb5ca442b874c2">                                                                                                                                                                                                                                                                                                                                                                                                       
  <script>
      $(document).ready(function() {
          CHV.obj.storages = ;
          CHV.obj.storageTemplate = {"messages":{"is_https":"Toggle this to enable or disable HTTPS","is_active":"Toggle this to enable or disable this storage"},"icon":"<span rel=\"toolTip\" data-tipTip=\"right\" title=\"%TITLE%\" class=\"cursor-pointer icon %ICON%\" data-checked-icon=\"far fa-check-square\" data-unchecked-icon=\"far fa-square\" data-action=\"toggle-storage-%PROP%\" data-checkbox><\/span>","checkboxes":["far fa-square","far fa-check-square"]};
      });
  </script>

Clicking on S3 bucket names:

chevereto.min.js?3dad49da22861122dfffe5896643ddd8:3 Uncaught TypeError: Cannot read properties of undefined (reading '2')
    at before (chevereto.min.js?3dad49da22861122dfffe5896643ddd8:3:27699)
    at HTMLAnchorElement.<anonymous> (peafowl.min.js?3dad49da22861122dfffe5896643ddd8:1:11156)
    at HTMLDocument.dispatch (scripts.min.js?3dad49da22861122dfffe5896643ddd8:3:8036)
    at v.handle (scripts.min.js?3dad49da22861122dfffe5896643ddd8:3:4749)

Clicking on S3 bucket "Active" checkbox:

chevereto.min.js?3dad49da22861122dfffe5896643ddd8:3 Uncaught TypeError: Cannot read properties of undefined (reading '1')
    at Object.toggleBool (chevereto.min.js?3dad49da22861122dfffe5896643ddd8:3:27039)
    at Object.toggleActive (chevereto.min.js?3dad49da22861122dfffe5896643ddd8:3:26840)
    at HTMLSpanElement.<anonymous> (chevereto.min.js?3dad49da22861122dfffe5896643ddd8:2:6136)
    at HTMLDocument.dispatch (scripts.min.js?3dad49da22861122dfffe5896643ddd8:3:8036)
    at v.handle (scripts.min.js?3dad49da22861122dfffe5896643ddd8:3:4749)

 

[siddharth]

I can confirm this bug. You can fix this by deleting the storage from DB ( make sure you export the table as backup ).

Change the counter to starting of the previous number of the deleted storage. And then add the storage back. It will get fixed.

But you will get upload issue after this. But uploads are working if the storage is clean. Not sure about the reason.

 

[Rodolfo]

This happens because the storage table is handling malformed characters. How that happened is something that I need to investigate, I think that it could be related to the conversion required to display these values but without real data it gets harder to narrow down the steps required to trigger this issue.

It will be awesome if one of you could send me (private) the chv_storages tables (as-is) + the conflicting storage credentials so I can perform more checks on the data.

Edit

I got a sample data to test! Seems that the issue is encryption related, chances are that failing to execute encrypt-secrets caused this or perhaps another combination of encryption stuff.

 

[Rodolfo]

Fixed in v4.0.0-beta.11