Image description and category erased on update

[lonepress]

This happens when images are updated via the json route with action=edit. For example, when using the "flag as unsafe" image overlay button.

The code calls Image::update(...), which calls G\nullify_string(...) on 'description' and 'category_id'. It looks like this call happens so that empty strings will be updated to null values in the database.

The problem is, if the $values array does not contain 'description' or 'category', this function adds them to the array with a null value, so the old values get erased.

I fixed it in Image::update by replacing this:

foreach(['description', 'category_id'] as $v) {
    G\nullify_string($values[$v]);
}

with this:

foreach(['description', 'category_id'] as $v) {
    if (array_key_exists($v, $values)) {
        G\nullify_string($values[$v]);
    }
}

 

[lonepress]

It also looks like the same problem exists in route.json.php when editing categories (it nullifies the category description), and in Album::update(...) (it nullifies the album description). It may not be a real issue there if callers always pass a description value through those code paths, but I'm not sure of that.

 

[Rodolfo]

Thanks, I've fixed it for 3.5.0 😉