Feedback on QQ login issues

[ChinaSouth]

EN：
I have found an issue where QQ login will generate an error message because QQ login is a strong verification method. Adding a "/" with a "/" will cause the verification method to fail, and QQ will prompt that the callback domain does not pass. So I made modifications to three places so that there won't be any errors!
First place:/app/legacy/routes/connect.chp, line 53
//Before modification
'callback' => get_public_url('connect/' . $doing) . '/',
//After modification
'callback' => get_public_url('connect/' . $doing),
After making the changes, I found that there is still a "/" in the callback domain position of QQ in the dashboard/dashboard/settings/login providers. Therefore, I made a second modification
Second place:/content/legal/themes/page/views/dashboard/settings/loginproviders.chp, line 85
//Before modification
'%connectUrlValue%' => get_base_url('connect/' . $name . '/', true),
//After modification
'%connectUrlValue%' => get_base_url('connect/' . $name, true),
Third place:/app/legacy/routes/json. php line 1603
//Before modification
'callback' => get_public_url('connect/' . $disconnect) . '/',
//After modification
'callback' => get_public_url('connect/' . $disconnect),
After modifying these three areas, QQ login will no longer prompt callback domain exceptions.
I hope the official can fix this issue as soon as possible. Thanks!


中文：
我发现一个问题，就是QQ登录会报错，因为QQ登录是强校验方式，你这里多一个“/”如果带“/”就会导致校验方式不通过，QQ会提示回调域不通过。所以我对三个地方进行了修改，这样就不会报错了！
第一处：/app/legacy/routes/connect.php 第 53 行
// 改前
'callback' => get_public_url('connect/' . $doing) . '/',

// 改后
'callback' => get_public_url('connect/' . $doing),
改完发现在仪表盘内/dashboard/settings/login-providers发现QQ的回调域位置还是有“/”的，那我进行了二次修改
第二处：/content/legacy/themes/Peafowl/views/dashboard/settings/login-providers.php第85行
//改前
'%connectUrlValue%' => get_base_url('connect/' . $name . '/', true),
//改后
'%connectUrlValue%' => get_base_url('connect/' . $name, true),
第三处：/app/legacy/routes/json.php第1603行
//改前
'callback' => get_public_url('connect/' . $disconnect) . '/',
//改后
'callback' => get_public_url('connect/' . $disconnect),
修改了这三处，QQ登录就不会提示回调域异常了。
希望官方能尽快修复此问题。感谢！

 

[Rodolfo]

The real fix isn't in Chevereto's code, it's in your QQ Connect (Tencent Open Platform) app settings.

Go to your QQ app's callback/redirect URL configuration and make sure the callback domain you registered there includes the trailing slash, matching exactly what Chevereto sends. QQ does strict string matching on the callback URL, so if what's registered on QQ's side doesn't match character-for-character (slash included or not) with what Chevereto generates, it'll reject it with the "callback domain" error.

Editing connect.php to strip the slash works too, but it's a workaround on Chevereto's end for a mismatch that should instead be fixed by aligning the URL registered in QQ's dashboard with what Chevereto actually generates.

Check the documentation: https://v4-admin.chevereto.com/features/login-providers.html#create-an-app

 

[ChinaSouth]

真正的修复不在Chevereto的代码中，而在你的QQ Connect(腾讯开放平台)应用设置中。

转到您的QQ应用程序的回拨/重定向URL配置，并确保您在那里注册了回拨域名包括尾部斜杠与切弗雷托发送的内容完全一致。QQ对回拨URL进行严格的字符串匹配，因此，如果在QQ端注册的内容与Chevereto生成的内容不完全匹配(包括或不包括斜线),它会以“回拨域”错误拒绝该内容。

编辑connect.php去掉斜线也可以，但这是Chevereto的一种变通办法，可以通过将QQ仪表盘中注册的URL与Chevereto实际生成的URL对齐来解决不匹配的问题。

查看文档:https://v4-admin . cheve reto . com/features/log in-providers . html # create-an-app

View attachment 6650

No, it's your mistake. I'm sorry to point out your mistake. The callback field of Tencent Open Platform does not allow slashes, as shown in the picture. You can check the rules of Tencent Open Platform~

 

[Rodolfo]

Then what we need is a special rule indicating that for this sole provider the thing must break our path convention, otherwise this change will break all the other gazillion providers we support already.

Does someone else know about other providers also complaining about trailing slash so I can add it to the change?