Delayed deletion causing conflict with image upload/deletion

[mkerala]

I have been seeing many images uploaded on the site showing 404 default image instead of original image. But couldn't figure out the reason.

Since, Chevereto moved to cronjob for handing the deletion, there is a slight delay of 1-3 mins before the file is actually deleted. Because of this, there is a conflict of uploading images with same file name.

▶ Reproduction steps

1. Upload a image with unique file name.
2. Delete the image.
3. Immediately upload the same image file again.
4. Wait 2-3 mins and access image link.

😢 Unexpected result

Both images got the exact same URL and filename in the system. So when the deletion job deleted the file, the second image started displaying default 404 image even though the image is still exists in DB.

Example: https://gifyu.com/image/5lNl

📃 Error log message

None

PS: I couldn't replicate the issue on demo as image deletion seems to be broken on Demo site. That is Image URLs are still active post deletion of images.

 

[Rodolfo]

That's not a bug, that's a race condition in your system. Use random filenaming, or hit the command more often or spawn more storage servers.

I couldn't replicate the issue on demo as image deletion seems to be broken on Demo site.

Demo does delete, is just that the request get cached. Don't worry, the files aren't in the server anymore after delete.