BBcode medium link = broken

[BMWracing]

I updated to 3.4.6 today and noticed that the medium bb code link after uploading images is broken.

It's giving me thumbnails and medium sized images in one post.. So in other words it's not constant.

 

[BMWracing]

Example

 

[Rodolfo]

Medium is not always generated, is only generated when is needed.

 

[BMWracing]

Is it not being generated because the medium dimensions are larger than the image?

I understand this behaviour, but I would like to suggest that when copying all the bb codes after uploading (batch copy) that it then uses the original image size and not the thumbnail versions when selecting to copy all medium bb codes.

So instead of my example above it would be medium + originals.

 

[Rodolfo]

Yeah, sounds that it will be better in that way.

 

[BMWracing]

Great! It was this way before, so I think you must have changed it in 3.45/3.4.6?

 

[Rodolfo]

Great! It was this way before, so I think you must have changed it in 3.45/3.4.6?

Sort of. I changed long time ago.

 

[BMWracing]

Thanks Rodolfo. Any chance you could provide me with a quick fix until 3.47 is released with the changed code?

 

[Rodolfo]

app/lib/chevereto.js change this:

        if(!image.medium) {
            image.medium = image.thumb;
        }

To this:

        // Medium doesn't exists
        if(!image.medium) {
            var imageProp = ["filename", "name", "width", "height", "ratio", "bits", "channels", "extension", "filename", "height", "mime", "name", "ratio", "size", "size_formatted", "url", "width"];
            image.medium = {};
            for(var i=0; i<imageProp.length; i++) {
                image.medium[imageProp[i]] = image[imageProp[i]];
            }
        }

 

[BMWracing]

Awesome. Thanks again mate! Please don't forget to change in 3.4.7 update for other members!

 

[BMWracing]

Hmm.. was a bit too fast.. getting all thumbnails now.

 

[BMWracing]

 

[Rodolfo]

Wait for the official/final patch.