Fixing ugly gif thumbnails?

[gifDB]

Hello,

So I'm really liking the improvements made in 2.0.9 so far. There's only one problem that I'm noticing right away.
The thumbnails being made from .gif images are hideous. I'm noticing chunks of white pixels all over them. This is a problem I didn't have with the 1.9.X release.

Here's a link so you can see what I'm talking about:
http://gifdb.com/browse.php

Any ideas on how to fix this? Thanks.

 

[Rodolfo]

This happens in the demo?

 

[gifDB]

Yep. It's happening in your demo as well as on my own site.

Example 1:
http://demo.chevereto.com/images/WfFIX.gif
http://demo.chevereto.com/images/thumbs/WfFIX.gif

Example 2:
http://demo.chevereto.com/images/B5ShN.gif
http://demo.chevereto.com/images/thumbs/B5ShN.gif

 

[gifDB]

Alright, so it looks like all of the white I'm seeing is just a transparency layer over my white background.
It must just be getting goofed up when it resizes the gif's.

Anyway, I found a half solution that works for me. I edited the .css file in my theme to include a new div with a black background.

#thumbs {
    background-color: #000000;
    width: 100;
    height: 90;
    float: left;
    overflow:hidden;
}

Then, where I post my thumbnails, I just encase them in those div elements.

$display .= "\t\t<div id='thumbs'><a href='http://gifdb.com/{$link}{$image}'><img width='100' height='90' src=\"{$where}{$image}\" /></a></div>\n";

As you can see, showing a black layer behind the transparency looks much nicer than the white.
http://gifdb.com/browse.php

Still doesn't really fix the root of the problem though.

Cheers.

 

[Rodolfo]

I Will have to check the upload class

 

[Rodolfo]

Ok, I have just find the problem.

The thing is that all the resizes pass to a filter to make prettier thumbs but on the .gif this just make ugly thumbs. This also make ugly thumbs when the image has transparency, just try to upload a png with alpha and you will notice it.

This is because a bug on the php imageconvolution function, so let's just filter the .jpg images...

open includes/classes/class.upload.php and replace this:

if(function_exists('imageconvolution')) {

with this:

if(function_exists('imageconvolution') && $extension=='jpg') {

This will be on 2.0.10