Chevereto 2.0.5

Status
Not open for further replies.

Rodolfo

The Chevere Guru
Chevereto Staff
Chevereto 2.0.5 (2011-12-07) release notes
- Fixed __CHV_RELATIVE_ROOT__ on WAMP servers
- Fixed bug regarding the upload button reset (original post)
- Added check for curl_exec() function
- Added Thai language

Upgrade from 2.0.4 | Affected files & folders
- includes/config.php
- includes/function.php
- content/system/js/peafowl.php
- content/languages/th

NOTE: The change in config.php is only in the line 159.
 

Cory

Founder license
License owner
Going over some code and I don't know of this is a mistake or purpose written.

/includes/functions.php

Code:
/**
 * generateRandomString
 * Generates the random string used in randomFile
 *
 * @autor    fabin dot gnu at gmail dot com
 * @url        http://www.php.net/manual/es/function.file-exists.php#88607
 */
function generateRandomString($length = 8) {
    $string = "";
    $possible = "0123456789abcdefghjkmnpqrstvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
    for($i=0;$i < $length;$i++) {
        $char = substr($possible, rand(0, strlen($possible)-1), 1);
        if (!strstr($string, $char)) {
            $string .= $char;
        }
    }
    return $string;
}
If you look at:

Code:
    $possible = "0123456789abcdefghjkmnpqrstvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
Either someone don't know the alphabet or this was written this way.

Forgot: ilou

Not a big issue...just figure I'll point it out.
 

Rodolfo

The Chevere Guru
Chevereto Staff
Cory said:
Going over some code and I don't know of this is a mistake or purpose written.

/includes/functions.php

Code:
/**
 * generateRandomString
 * Generates the random string used in randomFile
 *
 * @autor    fabin dot gnu at gmail dot com
 * @url        http://www.php.net/manual/es/function.file-exists.php#88607
 */
function generateRandomString($length = 8) {
    $string = "";
    $possible = "0123456789abcdefghjkmnpqrstvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
    for($i=0;$i < $length;$i++) {
        $char = substr($possible, rand(0, strlen($possible)-1), 1);
        if (!strstr($string, $char)) {
            $string .= $char;
        }
    }
    return $string;
}
If you look at:

Code:
    $possible = "0123456789abcdefghjkmnpqrstvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
Either someone don't know the alphabet or this was written this way.

Forgot: ilou

Not a big issue...just figure I'll point it out.
It will be fixed on 2.0.6
 
Status
Not open for further replies.
Top